comparison src/gui/widgets/anime_info.cc @ 187:9613d72b097e

*: multiple performance improvements like marking `static const` when it makes sense... date: change old stupid heap-based method to a structure which should make copying the thing actually make a copy. also many performance-based changes, like removing the std::tie dependency and forward-declaring nlohmann json *: replace every instance of QString::fromUtf8 to Strings::ToQString. the main difference is that our function will always convert exactly what is in the string, while some other times it would only convert up to the nearest NUL byte
author Paper <mrpapersonic@gmail.com>
date Wed, 06 Dec 2023 13:43:54 -0500
parents 80f49f623d30
children c4ca035c565d
comparison
equal deleted inserted replaced
186:6ef31dbb90ca 187:9613d72b097e
30 30
31 /* details */ 31 /* details */
32 QString details_data; 32 QString details_data;
33 QTextStream details_data_s(&details_data); 33 QTextStream details_data_s(&details_data);
34 /* we have to convert ALL of these strings to 34 /* we have to convert ALL of these strings to
35 QString because QTextStream sucks and assumes 35 * QString because QTextStream sucks and assumes
36 Latin1 (on Windows?) */ 36 * Latin1 (on Windows?)
37 */
37 details_data_s << Strings::ToQString(Translate::ToString(anime.GetFormat())) << "\n" 38 details_data_s << Strings::ToQString(Translate::ToString(anime.GetFormat())) << "\n"
38 << anime.GetEpisodes() << "\n" 39 << anime.GetEpisodes() << "\n"
39 << Strings::ToQString(Translate::ToString(anime.GetUserStatus())) << "\n" 40 << Strings::ToQString(Translate::ToString(anime.GetUserStatus())) << "\n"
40 << Strings::ToQString(Translate::ToString(anime.GetSeason())) << " " 41 << Strings::ToQString(Translate::ToString(anime.GetSeason())) << " "
41 << anime.GetAirDate().GetYear() << "\n" 42 << anime.GetAirDate().GetYear() << "\n"