Mercurial > minori
diff dep/animia/src/strategist.cc @ 150:ffa535b6d630
*: avoid usage of std::[pair,tuple]
https://arne-mertz.de/2017/03/smelly-pair-tuple/
it's better to use real structures and such where variables are easily known...
also apparently using [] on structs is actually valid? I had no idea.
author | Paper <mrpapersonic@gmail.com> |
---|---|
date | Tue, 14 Nov 2023 16:27:33 -0500 |
parents | aa4df5a84338 |
children | 54744a48a7d7 |
line wrap: on
line diff
--- a/dep/animia/src/strategist.cc Tue Nov 14 13:40:11 2023 -0500 +++ b/dep/animia/src/strategist.cc Tue Nov 14 16:27:33 2023 -0500 @@ -50,12 +50,12 @@ bool success = false; const std::set<pid_t> pids{result_.process.pid}; - std::vector<std::pair<pid_t, std::string>> files; + std::vector<OpenFile> files; fd.EnumerateOpenFiles(pids, files); - for (const auto& [pid, file] : files) { - success |= AddMedia({MediaInfoType::File, file}); + for (const auto& file : files) { + success |= AddMedia({MediaInfoType::File, file.path}); } return success;