view src/core/http.cc @ 396:8ed3b5e8f205

http: fix double-free
author Paper <paper@tflc.us>
date Fri, 07 Nov 2025 07:56:03 -0500
parents 963047512d34
children 811697ad826a
line wrap: on
line source

#include "core/http.h"
#include "core/session.h"
#include <QByteArray>
#include <curl/curl.h>
#include <iostream>
#include <string>
#include <vector>

namespace HTTP {

std::string UrlEncode(const std::string &data)
{
	/* why do I need to init curl just for this? wtf? */
	CURL *curl = curl_easy_init();
	if (!curl)
		return ""; /* no way! */

	char *output = curl_easy_escape(curl, data.data(), data.size());
	if (!output) {
		curl_easy_cleanup(curl);
		return "";
	}

	std::string str(output);

	curl_free(output);
	curl_easy_cleanup(curl);

	return str;
}

std::string UrlDecode(const std::string &data)
{
	CURL *curl = curl_easy_init();
	if (!curl)
		return "";

	int outlength;
	char *output = curl_easy_unescape(curl, data.data(), data.size(), &outlength);
	if (!output) {
		curl_easy_cleanup(curl);
		return "";
	}

	std::string str(output, outlength);

	curl_free(output);
	curl_easy_cleanup(curl);

	return str;
}

std::string EncodeParamsList(std::string base, const std::map<std::string, std::string> &params)
{
	std::size_t count = 0;
	for (const auto &param : params) {
		base += (!count ? "?" : "&");
		base += UrlEncode(param.first);
		base += "=";
		base += UrlEncode(param.second);

		count++;
	}

	return base;
}

static void SetCurlOpts(CURL *curl, const std::string &url, const std::vector<std::string> &headers,
                        const std::string &data, Type type)
{
	struct curl_slist *list;

	curl_easy_setopt(curl, CURLOPT_URL, url.c_str());

	list = NULL;
	for (const std::string &h : headers)
		list = curl_slist_append(list, h.c_str());
	curl_easy_setopt(curl, CURLOPT_HTTPHEADER, list);

	switch (type) {
	case Type::Patch:
		curl_easy_setopt(curl, CURLOPT_CUSTOMREQUEST, "PATCH");
		[[fallthrough]];
	case Type::Post:
		curl_easy_setopt(curl, CURLOPT_POSTFIELDS, data.c_str());
		break;
	case Type::Get:
		break;
	}

	curl_easy_setopt(curl, CURLOPT_SSL_OPTIONS, CURLSSLOPT_NATIVE_CA);
	curl_easy_setopt(curl, CURLOPT_NOSIGNAL, 1L); // threading
}

static size_t WriteCallback(void *contents, size_t size, size_t nmemb, void *userdata)
{
	reinterpret_cast<QByteArray *>(userdata)->append(reinterpret_cast<char *>(contents), size * nmemb);
	return size * nmemb;
}

QByteArray Request(const std::string &url, const std::vector<std::string> &headers, const std::string &data, Type type)
{
	QByteArray userdata;

	CURL *curl = curl_easy_init();
	if (curl) {
		SetCurlOpts(curl, url, headers, data, type);

		/* Use our specific userdata & write callback
		 * TODO can this just be a lambda instead */
		curl_easy_setopt(curl, CURLOPT_WRITEDATA, &userdata);
		curl_easy_setopt(curl, CURLOPT_WRITEFUNCTION, &WriteCallback);

		CURLcode res = curl_easy_perform(curl);
		session.IncrementRequests();
		curl_easy_cleanup(curl);
		if (res != CURLE_OK)
			session.SetStatusBar(std::string("curl_easy_perform(curl) failed!: ") + curl_easy_strerror(res));
	}
	return userdata;
}

/* this function is static */
size_t RequestThread::WriteCallback(void *contents, size_t size, size_t nmemb, void *userdata)
{
	RequestThread *thread = reinterpret_cast<RequestThread *>(userdata);

	if (thread->cancelled_)
		return CURL_WRITEFUNC_ERROR;

	/* else, continue on as normal */
	thread->array_.append(reinterpret_cast<char *>(contents), size * nmemb);
	return size * nmemb;
}

RequestThread::RequestThread(Type type, QObject *parent) : QThread(parent)
{
	SetType(type);
}

RequestThread::RequestThread(const std::string &url, const std::vector<std::string> &headers, const std::string &data,
                             Type type, QObject *parent)
    : QThread(parent)
{
	SetUrl(url);
	SetData(data);
	SetHeaders(headers);
	SetType(type);
}

RequestThread::~RequestThread()
{
	/* block until the function can safely exit */
	Stop();
	wait();

	/* Kill off any curl thing we made */
	if (curl_)
		curl_easy_cleanup(reinterpret_cast<CURL *>(curl_));
}

void RequestThread::SetUrl(const std::string &url)
{
	url_ = url;
}

void RequestThread::SetHeaders(const std::vector<std::string> &headers)
{
	headers_ = headers;
}

void RequestThread::SetData(const std::string &data)
{
	data_ = data;
}

void RequestThread::SetType(Type type)
{
	type_ = type;
}

void RequestThread::run()
{
	/* If we don't have a curl object, create one */
	if (!curl_) {
		curl_ = reinterpret_cast<void *>(curl_easy_init());
	}

	CURL *curl = reinterpret_cast<CURL *>(curl_);

	if (curl) {
		SetCurlOpts(curl, url_, headers_, data_, type_);

		curl_easy_setopt(curl, CURLOPT_WRITEDATA, this);
		curl_easy_setopt(curl, CURLOPT_WRITEFUNCTION, &RequestThread::WriteCallback);

		CURLcode res = curl_easy_perform(curl);
		session.IncrementRequests();

		if (res != CURLE_OK && !(res == CURLE_WRITE_ERROR && cancelled_))
			session.SetStatusBar(std::string("curl_easy_perform(curl) failed!: ") + curl_easy_strerror(res));
	}

	emit ReceivedData(array_);
	/* Clear it out for any subsequent runs */
	array_.clear();
}

void RequestThread::Stop()
{
	cancelled_ = true;
}

} // namespace HTTP