Mercurial > minori
view src/gui/dialog/settings/recognition.cc @ 187:9613d72b097e
*: multiple performance improvements
like marking `static const` when it makes sense...
date: change old stupid heap-based method to a structure which should
make copying the thing actually make a copy.
also many performance-based changes, like removing the std::tie
dependency and forward-declaring nlohmann json
*: replace every instance of QString::fromUtf8 to Strings::ToQString.
the main difference is that our function will always convert exactly
what is in the string, while some other times it would only convert
up to the nearest NUL byte
author | Paper <mrpapersonic@gmail.com> |
---|---|
date | Wed, 06 Dec 2023 13:43:54 -0500 |
parents | ffa535b6d630 |
children | ff0061e75f0f |
line wrap: on
line source
#include "core/session.h" #include "core/strings.h" #include "gui/dialog/settings.h" #include <QListWidget> #include <QListWidgetItem> #include <QGroupBox> #include <QCheckBox> #include <QLabel> #include <QSizePolicy> #include <QVBoxLayout> #include <algorithm> QWidget* SettingsPageRecognition::CreatePlayersWidget() { QWidget* result = new QWidget(this); result->setAutoFillBackground(true); result->setSizePolicy(QSizePolicy::Expanding, QSizePolicy::Maximum); QVBoxLayout* full_layout = new QVBoxLayout(result); { /* Feed link */ QWidget* widget = new QWidget(result); QVBoxLayout* widget_layout = new QVBoxLayout(widget); QCheckBox* checkbox = new QCheckBox(result); checkbox->setText(tr("Enable media player detection")); checkbox->setCheckState(detect_media_players ? Qt::Checked : Qt::Unchecked); widget_layout->addWidget(checkbox); { QLabel* label = new QLabel(tr("Allowed media players:"), widget); widget_layout->addWidget(label); } { QListWidget* listwidget = new QListWidget(widget); for (size_t i = 0; i < players.size(); i++) { const auto& [enabled, player] = players[i]; if (player.type == animia::PlayerType::Default) { QListWidgetItem* item = new QListWidgetItem(listwidget); item->setCheckState(enabled ? Qt::Checked : Qt::Unchecked); item->setText(Strings::ToQString(player.name)); item->setData(Qt::UserRole, QVariant::fromValue(i)); } } connect(listwidget, &QListWidget::itemChanged, this, [this](QListWidgetItem* item){ if (!item) return; size_t i = item->data(Qt::UserRole).toUInt(); players[i].enabled = item->checkState(); }); /* this is down here because the listwidget state depends on it */ connect(checkbox, &QCheckBox::stateChanged, this, [this, listwidget](int state) { detect_media_players = (state == Qt::Checked); listwidget->setEnabled(detect_media_players); }); listwidget->setEnabled(checkbox->checkState() == Qt::Checked); widget_layout->addWidget(listwidget); } full_layout->addWidget(widget); } full_layout->setSpacing(10); return result; } void SettingsPageRecognition::SaveInfo() { session.config.recognition.detect_media_players = detect_media_players; session.config.recognition.players = players; } SettingsPageRecognition::SettingsPageRecognition(QWidget* parent) : SettingsPage(parent, tr("Recognition")), players(session.config.recognition.players) { detect_media_players = session.config.recognition.detect_media_players; AddTab(CreatePlayersWidget(), tr("Media players")); }